Support convention-based DependentUpon for resx files in folders #4702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the old convention. Fixes dotnet#4695.
rainersigwald
added
Area: Tasks
nguerrera
approved these changes
Sep 6, 2019
rainersigwald
added
the
Approved to merge
rainersigwald
added a commit
to rainersigwald/core
that referenced
this pull request
Sep 25, 2019
This was resolved before RTW by dotnet/msbuild#4702.
vivmishra
pushed a commit
to dotnet/core
that referenced
this pull request
Sep 30, 2019
* Remove resx-in-subfolder known issue This was resolved before RTW by dotnet/msbuild#4702. * Mark preview issue as resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #4695, build failures that arise when a
.resxfile does not specifyDependentUponand is in a subfolder.Customer Impact
Builds fail with
MSB3041. Impacts EF migrations (dotnet/ef6#1225), some WinForms projects, and some plain-vanilla projects.Workaround
Users can explicitly opt out of the new behavior back into preview8 behavior with a property
Or explicitly specify
DependentUponfor all resources:Regression?
Yes, builds fail in cases that passed before. Introduced with #4597, a new feature to support resources without project-file impact.
Testing
Automated tests, including a new one for this specific case. e2e validation in failing scenarios using privates.
Risk
Low. Targeted fix in a conditioned codepath, so the existing workarounds will continue to work and can mitigate any problems.